Blob'ing NetBSD
Creation:10-05-2013 | Update:14-04-2014

27/06/2013 --------------------------- 1 ------------------------------------

Scanned folders: sys/* libexec/*
RED: #16, important
ORANGE: #3, not very important
GREEN: #19, solved

# 01 SYS/ARCH/
0x01 FALSE POSITIVE|UNINITIALIZED VARIABLE: acorn26/acorn26/cpu.c rev1.28
     At l.156, if (setjmp(&undef_jmp) != 0), 'id' is not initialized at l.166.
0x02 FIXED-rev1.10|LEAK: alpha/eisa/eisa_machdep.c rev1.9
     At l.267, 'ecuio' is leaked in the loop.
0x03 FIXED-rev1.4|UNINITIALIZED VARIABLE: ia64/stand/common/fileload.c rev1.3
     At l.96, 'error' may not be initialized.
0x04 FIXED-rev1.9|LEAK: mipsco/stand/installboot/installboot.c rev1.8
     At l.185, 'boot_code' is never freed.
OxO5 FIXED-rev1.19|LEAK: sgimips/stand/sgivol/sgivol.c rev1.18
     At l.532, 'fp' is leaked.
0x06 FIXED-rev1.26|OVERLAP: prep/prep/autoconf.c rev1.25
     At lines 168, 175, 189, 191, 197, 200, using sprintf() with the same src
     and dest can result in an undefined behavior.

# 02 SYS/DEV/
0x01 FIXED-rev1.27|UNINITIALIZED VARIABLE: hpc/hpf1275a_tty.c rev1.26
     At l.332, 'sc' is not initialized, and does not even seem to be used.
0x02 FIXED-rev1.49|UNINITIALIZED VARIABLE: ic/mfi.c rev1.48
     At l.373, if (sc->sc_ioptype != MFI_IOP_TBOLT), 'io_req_base_phys' is not
     initialized at l.417.
0x03 FIXED-rev1.49|UNINITIALIZED VARIABLE: ic/mfi.c rev1.48
     At l.373, if (sc->sc_ioptype != MFI_IOP_TBOLT), 'io_req_base' is not
     initialized at l.415.
0x04 FIXED-rev1.40|OVERLAP: ic/opl.c rev1.39
     At l.161, using snprintf() with the same src and dest can result in an
     undefined behavior.
0x05 FIXED-rev1.22|UNINITIALIZED VARIABLE: pci/pm2fb.c rev1.21
     From l.1351 to l.1356, 'n' is not initialized.

# 03 SYS/FS/ - with optimization rules
0x01 FIXED-rev1.3|LEAK: v7fs/v7fs_io.c rev1.2
     At l.99, 'buf' is leaked.
0x02 FIXED-rev1.50|USELESS INITIALIZATION: ntfs/ntfs_subr.c rev1.49
     At l.1789, it's useless to assign a value to the variable 'off' as it is
     reassigned at l.1811.

# 04 SYS/KERN/ - with optimization rules
0x01 FALSE POSITIVE|UNINITIALIZED VARIABLE: kern_sysctl.c rev1.243
     At l.1737, if (newp == NULL), 'dnode' is not initialized at l.1875.
0x02 FIXED-rev1.464|UNINITIALIZED VARIABLE: vfs_syscalls.c rev1.463
     At l.3188, if (vp->v_type != VLNK), 'auio' is not initialized at l.3204.
     It has already been fixed in OpenBSD, so you should have a look here.
0x03 FIXED-rev1.227|USELESS INITIALIZATION: subr_autoconf.c rev1.226
     At l.244, it's useless to assign a value to the variable 'i' as it is
     reassigned at l.246.
0x04 FIXED-rev1.245|USELESS INITIALIZATION: vfs_bio.c rev1.244
     At l.1439, it's useless to assign a value to the variable 'size' as it is
     reassigned at l.1448.

# 05 SYS/NFS/
0x01 FALSE POSITIVE|UNINITIALIZED VARIABLE: nfs_serv.c rev1.165
     At l.741, 'mb' is used whereas it is not initialized. It looks like you
     will have to revert the lines 741 and 742.

# 06 LIBEXEC/TELNETD/
0x01 FIXED-rev1.47|PTR DEREFERENCE: sys_term.c rev1.46
     At l.703, 'nargv' is not null-checked. It seems that someone mistakenly
     put 'argv' instead of 'nargv' at l.705. It can cause crashes.

---------------------------------------------------------------------------------

0x01 FIXED-rev1.4|DEAD CODE: sys/dev/acpi/tpm_acpi.c rev1.3
     At l.190, some {} are missing. The function always jumps to 'out1'.
0x02 FIXED-rev1.21|UNINITIALIZED VARIABLE: sys/arch/arm/ep93xx/epclk.c rev1.20
     At l.157, 'first_run' may not be initialized.
0x03 FIXED-rev1.156|LEAK: sys/netinet/if_arp.c rev1.155
     At l.1477, 'm' is leaked.